Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure stdcm form and simulations clear on page refresh #9922

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Ensure stdcm form and simulations clear on page refresh #9922

merged 1 commit into from
Dec 16, 2024

Conversation

achrafmohye
Copy link
Contributor

Closes #9754

@achrafmohye achrafmohye self-assigned this Dec 3, 2024
@github-actions github-actions bot added the area:front Work on Standard OSRD Interface modules label Dec 3, 2024
@achrafmohye achrafmohye requested a review from Akctarus December 3, 2024 09:25
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.79%. Comparing base (575dbe6) to head (206a3be).
Report is 7 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #9922      +/-   ##
==========================================
- Coverage   79.81%   79.79%   -0.02%     
==========================================
  Files        1052     1052              
  Lines      105434   105439       +5     
  Branches      727      727              
==========================================
- Hits        84147    84139       -8     
- Misses      21245    21258      +13     
  Partials       42       42
Flag Coverage Δ
editoast 73.70% <ø> (-0.05%) ⬇️
front 89.12% <100.00%> (+<0.01%) ⬆️
gateway 2.18% <ø> (ø)
osrdyne 3.28% <ø> (ø)
railjson_generator 87.50% <ø> (ø)
tests 87.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emersion
Copy link
Member

emersion commented Dec 3, 2024

Curious, I would've expected that to already be the case, seeing how stdcmConfSlice is in the blacklist in persistConfig.

@achrafmohye achrafmohye marked this pull request as ready for review December 6, 2024 11:09
@achrafmohye achrafmohye requested a review from a team as a code owner December 6, 2024 11:09
Akctarus
Akctarus approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, lgtm !

@achrafmohye achrafmohye force-pushed the ame/stdcm-page-refresh-clears-form branch 3 times, most recently from 3d92ef1 to 85367c1 Compare December 13, 2024 10:33
SharglutDev
SharglutDev approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and tested (don't forget to fixup your commits)

@achrafmohye achrafmohye force-pushed the ame/stdcm-page-refresh-clears-form branch from 85367c1 to 8c78e00 Compare December 13, 2024 13:37
@achrafmohye achrafmohye force-pushed the ame/stdcm-page-refresh-clears-form branch from 8c78e00 to 179937f Compare December 13, 2024 13:40
@achrafmohye
front: ensure stdcm form and simulations clear on page refresh
206a3be 
Signed-off-by: Achraf Mohyeddine <a.mohyeddine@gmail.com>
@achrafmohye achrafmohye force-pushed the ame/stdcm-page-refresh-clears-form branch from 179937f to 206a3be Compare December 16, 2024 14:49
@achrafmohye achrafmohye added this pull request to the merge queue Dec 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 16, 2024
@achrafmohye achrafmohye added this pull request to the merge queue Dec 16, 2024
Merged via the queue into dev with commit 9dbea53 Dec 16, 2024
27 checks passed
@achrafmohye achrafmohye deleted the ame/stdcm-page-refresh-clears-form branch December 16, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SharglutDev SharglutDev SharglutDev approved these changes

@Akctarus Akctarus Akctarus approved these changes

Assignees

@achrafmohye achrafmohye

Labels
area:front Work on Standard OSRD Interface modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LMR Refreshing the page completely clears the form and any simulations below.
5 participants
@achrafmohye @codecov-commenter @emersion @Akctarus @SharglutDev